Simplify agents and teams cards#1199
Conversation
klopez4212
force-pushed
the
kennylopez-agents-page-cards
branch
from
9b87d11 to
60822a4
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60822a4471
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <DropdownMenuItem onClick={() => onOpenLogs(agent.pubkey)}> | ||
| <FileText className="h-4 w-4" /> | ||
| View logs |
There was a problem hiding this comment.
For local agents this menu item still calls onOpenLogs, which only updates logAgentPubkey in AgentsView. In this new card layout, UnifiedAgentsSection no longer renders ManagedAgentLogPanel/managed-agent-log-row or consumes logContent, logError, logLoading, or selectedLogAgentPubkey; the only remaining renderer is ManagedAgentRow, which is no longer mounted here. As a result, choosing View logs, or creating an agent which selects its logs, silently changes state with no logs visible.
Useful? React with 👍 / 👎.
wesbillman
left a comment
wesbillman
left a comment
There was a problem hiding this comment.
Thanks for simplifying the card layout. I found a blocker in the refactor: the local-agent View logs action is still present, but the new card UI no longer renders the selected log panel. I also noticed team descriptions are still passed into the card component but are no longer surfaced.
| </DropdownMenuItem> | ||
|
|
||
| {agent.backend.type === "local" ? ( | ||
| <DropdownMenuItem onClick={() => onOpenLogs(agent.pubkey)}> |
There was a problem hiding this comment.
This action now appears to be a no-op. It still sets the selected log pubkey via onOpenLogs(agent.pubkey), and AgentsView still passes logContent/logError/logLoading/selectedLogAgentPubkey into UnifiedAgentsSection, but the new card layout never renders ManagedAgentLogPanel (or any equivalent) based on that selected state. Before this refactor, ManagedAgentRow expanded the inline log panel. Please either restore a working log viewer for selected local-agent cards or remove/replace this menu item with a working pattern.
| actions: ReactNode; | ||
| children?: ReactNode; | ||
| dataTestId: string; | ||
| description?: string | null; |
There was a problem hiding this comment.
TeamsSection passes description={team.description} into this card, and the prop is declared here, but the component never destructures or renders it. The previous team card exposed descriptions through an info tooltip, so this loses user-visible team metadata. Please restore a way to view the description (or intentionally remove the prop/call site if descriptions are no longer meant to show here).
2 participants
Summary
Notes
Validation
cd desktop && pnpm checkcd desktop && pnpm typecheckgit diff --check